karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.45k stars 881 forks source link

[lfx-mentorship-2023-March-May] Enhance Karmada testing coverage #3086

Closed RainbowMango closed 1 year ago

RainbowMango commented 1 year ago

CNCF LFX mentorship https://github.com/cncf/mentoring/tree/main/lfx-mentorship/2023/01-Mar-May

Mentor: @XiShanYongYe-Chang

What would you like to be added: Karmada would like to improve the UT coverage of the code to better maintain the quality of the code and reduce the introduction of defects.

Increase the UT coverage rate to 65% (currently, the UT coverage rate is 43% ), increase the code coverage rate by about 20%.

Why is this needed:

Shubham4359 commented 1 year ago

Hi @RainbowMango I would like to work on this issue in the upcoming LFX mentorship term. I have prior experience of working with Unit Tests. Can you give me a brief idea about the prerequisites needed to learn and is there anything else that needs to be looked into?

swaingotnochill commented 1 year ago

Hi @RainbowMango, I have been trying to understand various projects in CNCF ecosystem and particularly interested in projects releated to Kubernetes as I wish to learn and work more on them. So, I would like to get involved in this project as I feel I will get the birdseye view writing tests and learning overall about the project. Any help is appreciated to get started.

Additionally, what do i need to do to improve the LFX Mentee application, do i need to have previous knowledge of Karmada or previous contributions in the repository( i think every org has their own way of selecting)?

OliverShang commented 1 year ago

Hi @RainbowMango, I am a senior software engineering student at Tongji University and would like to contribute to this project. I have previous internship experience on Golang and Unit Test. I'll apply for the mentorship once the applications are open, is there anything else that needs to be taken care of?

Thanks

avinabneogy23 commented 1 year ago

Hey @RainbowMango , I am a junior engineering student and would love to contribute to this project. I have previous experience using Golang and would love any pointers on getting started.

Daz-3ux commented 1 year ago

Hello @XiShanYongYe-Chang, As a computer science student in my second year, I am intrigued by the open-source community but have yet to get involved. I was hoping you could help me out by giving me a brief rundown of what I need to know before starting to learn Karmada, and if there's anything else I should keep in mind. Thank you!

XiShanYongYe-Chang commented 1 year ago

Hello everyone, @Shubham4359 @swaingotnochill @OliverShang @aomine2023 @Daz-3ux, we are glad to hear from you. I think you can go to the lfx mentorship website to submit the application to the current project: https://mentorship.lfx.linuxfoundation.org/project/1b2c5ff4-d6ea-4ca5-b138-75fce03407b4

J0SAL commented 1 year ago

Hey @XiShanYongYe-Chang , I would love to work on this issue. my profile

I am a full-stack developer with practical knowledge in Languages like JavaScript, Python, React, NextJS, Flask, and tools like Git, and Github. Currently, I am exploring Golang. I also have some experience writing UTs with the chai and mocha frameworks for my project. I am also a freelance content creator at GeeksForGeeks.

I have submitted the application for LFX mentorship!

XiShanYongYe-Chang commented 1 year ago

/close The relevant task will be tracked by #3327

/assign @realnumber666

karmada-bot commented 1 year ago

@XiShanYongYe-Chang: GitHub didn't allow me to assign the following users: realnumber666.

Note that only karmada-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/karmada-io/karmada/issues/3086#issuecomment-1482508799): >/close >The relevant task will be tracked by #3327 > >/assign @realnumber666 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
karmada-bot commented 1 year ago

@XiShanYongYe-Chang: Closing this issue.

In response to [this](https://github.com/karmada-io/karmada/issues/3086#issuecomment-1482508799): >/close >The relevant task will be tracked by #3327 > >/assign @realnumber666 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.