Closed liangyuanpeng closed 11 months ago
Merging #3580 (87fcabb) into master (218a0b2) will decrease coverage by
0.01%
. The diff coverage isn/a
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #3580 +/- ##
==========================================
- Coverage 55.86% 55.85% -0.01%
==========================================
Files 216 216
Lines 20121 20121
==========================================
- Hits 11240 11238 -2
- Misses 8276 8278 +2
Partials 605 605
Flag | Coverage Δ | |
---|---|---|
unittests | 55.85% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
/assign @calvin0327
thanks /lgtm
@liangyuanpeng Please retry the ci worlflow, you can push the branch again.
Please retry the ci worlflow, you can push the branch again.
Thanks for your remind and I think it's not necessary to rerun ci, the ci fail is not about this PR. And we have not ci for this doc.
Created issue to tracing it. https://github.com/karmada-io/karmada/issues/3583
The CI fail for E2E delete kind cluster failed, ask @RainbowMango to help rerun the test. /cc @RainbowMango
@liangyuanpeng Yeah, the failed ci workflow is not relate to the PR, But it is better to follow that the ci workflow of every PR is passed.
The CI fail for E2E delete kind cluster failed, ask @RainbowMango to help rerun the test. /cc @RainbowMango
Done
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Poor12
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Today, It will be failed when follow the doc to create karmada instance.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: