Closed zishen closed 11 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Merging #3598 (62c98ca) into master (234552a) will decrease coverage by
0.01%
. The diff coverage is43.13%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #3598 +/- ##
==========================================
- Coverage 55.83% 55.82% -0.01%
==========================================
Files 216 220 +4
Lines 20129 20612 +483
==========================================
+ Hits 11239 11507 +268
- Misses 8285 8493 +208
- Partials 605 612 +7
Flag | Coverage Δ | |
---|---|---|
unittests | 55.82% <43.13%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/util/lifted/corehelpers.go | 50.00% <ø> (ø) |
|
pkg/util/lifted/corev1helpers.go | 27.77% <ø> (+11.11%) |
:arrow_up: |
pkg/util/lifted/corevalidation.go | 37.14% <ø> (ø) |
|
pkg/util/lifted/genutils.go | 78.57% <ø> (ø) |
|
pkg/util/lifted/podtemplate.go | 0.00% <ø> (ø) |
|
pkg/util/lifted/requestinfo.go | 84.61% <0.00%> (-10.29%) |
:arrow_down: |
pkg/util/lifted/resourcename.go | 0.00% <ø> (ø) |
|
...ted/scheduler/framework/parallelize/parallelism.go | 56.25% <ø> (ø) |
|
pkg/util/lifted/taint.go | 91.89% <ø> (ø) |
|
pkg/util/lifted/validateclustertaints.go | 0.00% <0.00%> (ø) |
|
... and 9 more |
Why closed?
What type of PR is this? /kind cleanup
What this PR does / why we need it: For kamarda is based on k8s 1.26, but most lifted files are in 1.23. So we need synchronize files to version 1.26 of k8s.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer: update lifted files to k8s 1.26
Does this PR introduce a user-facing change?: NONE