Closed jwcesign closed 11 months ago
The testing report: https://docs.google.com/document/d/1DBm1fABxV_C5kPwv-ym3Im1i7jGGYAqDm5ERd_fieP8/edit#
Merging #3600 (4e365ba) into master (18c70c8) will decrease coverage by
0.61%
. The diff coverage is0.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #3600 +/- ##
==========================================
- Coverage 55.85% 55.25% -0.61%
==========================================
Files 220 221 +1
Lines 20595 20820 +225
==========================================
Hits 11504 11504
- Misses 8482 8706 +224
- Partials 609 610 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 55.25% <0.00%> (-0.61%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/util/lifted/corehelpers.go | 7.54% <0.00%> (-42.46%) |
:arrow_down: |
pkg/util/lifted/validatingfhpa.go | 0.00% <0.00%> (ø) |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
New changes are detected. LGTM label has been removed.
i think karmdactl
andkarmada-operator
also need this patch. @jwcesign
i think karmdactl and karmada-operator also need this patch. @jwcesign
Today is the release day, we can do it later.
What type of PR is this? /kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: None
Special notes for your reviewer: I will rebase the commits after https://github.com/karmada-io/karmada/pull/3589.
Does this PR introduce a user-facing change?: