Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` - Githubissues

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration

https://karmada.io

Apache License 2.0

4.11k stars 802 forks source link

Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` #3621

Closed realnumber666 closed 10 months ago

realnumber666 commented 10 months ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: Promote UT coverage

Which issue(s) this PR fixes: Part of #3327

Does this PR introduce a user-facing change?: NONE

codecov-commenter commented 10 months ago

Codecov Report

Merging #3621 (e97d295) into master (6089fa3) will increase coverage by 0.95%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
+ Coverage   54.80%   55.76%   +0.95%     
==========================================
  Files         216      221       +5     
  Lines       20121    20831     +710     
==========================================
+ Hits        11028    11617     +589     
- Misses       8495     8602     +107     
- Partials      598      612      +14

Flag	Coverage Δ
unittests	`55.76% <ø> (+0.95%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

XiShanYongYe-Chang commented 10 months ago

Hi @realnumber666 Thanks~ Can you help write the title more precisely, so that the follow-up inquiry is convenient?

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

RainbowMango commented 10 months ago

Sorry for the junk replies... That is due to GitHub was slow respond and I clicked multiple times submit...

XiShanYongYe-Chang commented 10 months ago

There is an occasional error, I have raised an issue to record it #3640 and ask @RainbowMango to help rerun the test. /cc @RainbowMango

RainbowMango commented 10 months ago

Done.