search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.48k stars 888 forks source link

Use MCS source name/cluster labels for EndpointSlice #3655

Open chaunceyjiang opened 1 year ago

chaunceyjiang commented 1 year ago

What would you like to be added:

Currently, the Karmada community is introducing MultiClusterService.

Before introducing it, I checked the current implementation of MCS in Karmada and found that some parts were missing.

Karmada should be consistent with upstream.

Why is this needed:

multicluster.kubernetes.io/service-name and multicluster.kubernetes.io/source-cluster label is added, per https://github.com/kubernetes/enhancements/tree/master/keps/sig-multicluster/1645-multi-cluster-services-api#importing-services

Other communities have already consistent with upstream, such as Submariner.

https://github.com/submariner-io/lighthouse/pull/681

chaunceyjiang commented 1 year ago

/assign

XiShanYongYe-Chang commented 1 year ago

@chaunceyjiang Thanks. These two labels were not previously used, which is why they were not added. However, we can add them now to ensure consistency with upstream.

chaunceyjiang commented 1 year ago

ok , i will work on this issue.