Open wu0407 opened 1 year ago
Thanks your feedback.
/assign
Thanks for reminding. We only support cleanup when certs mode is "auto". I think we should support it when certs mode is "custom" BTW, rbac cannot be auto cleanup, see https://github.com/karmada-io/karmada/tree/master/charts/karmada#uninstalling-the-chart.
What happened:
.Values.installMode=="host"
and.Values.certs.mode "auto"
Theapiservices.apiregistration
validatingwebhookconfigurations
mutatingwebhookconfigurations clusterroles.rbac
configmap
and so on remain in cluster after helm uninstall. https://github.com/karmada-io/karmada/blob/d27faeac953043c2274bb8787bbbaaafa7d0dcd6/charts/karmada/templates/pre-install-job.yaml#L74-L90 The root case is post-delete-job not mountstatic-resources
configmap https://github.com/karmada-io/karmada/blob/d27faeac953043c2274bb8787bbbaaafa7d0dcd6/charts/karmada/templates/post-delete-job.yaml#L45-L92.Values.installMode=="host"
and.Values.certs.mode "custom"
not clean any resource that create bypost-install-job
https://github.com/karmada-io/karmada/blob/d27faeac953043c2274bb8787bbbaaafa7d0dcd6/charts/karmada/templates/post-install-job.yaml#L1-L3What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl-karmada version
orkarmadactl version
):