karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

karmadactl supports top node #4224

Open zhzhuang-zju opened 5 months ago

zhzhuang-zju commented 5 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: karmadactl supports top node

Which issue(s) this PR fixes: Parts of #4217

Special notes for your reviewer: none

Does this PR introduce a user-facing change?:

Add command karmadactl top node to query the resource status of the cluster node. Like
➜  karmada git:(top) ✗ karmadactl top node -Cmember1
NAME                    CLUSTER   CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%   
member1-control-plane   member1   90m          2%     876Mi           5% 
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d73e47b) 52.83% compared to head (eebd5f6) 52.82%. Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4224 +/- ## ========================================== - Coverage 52.83% 52.82% -0.02% ========================================== Files 240 240 Lines 23595 23595 ========================================== - Hits 12467 12464 -3 - Misses 10452 10454 +2 - Partials 676 677 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `52.82% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chaunceyjiang commented 5 months ago

/assign

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chaunceyjiang after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/karmadactl/top/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/top/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhzhuang-zju commented 2 weeks ago

kindly ping @chaunceyjiang @RainbowMango