karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 813 forks source link

[Umbrella] Use permanent-id to replace namespace/name labels in the resource #4711

Open XiShanYongYe-Chang opened 2 months ago

XiShanYongYe-Chang commented 2 months ago

What would you like to be added:

Please ref to https://github.com/karmada-io/karmada/issues/4683#issuecomment-1996604867

Why is this needed:

Continue the work of #4000 and break down the tasks to be done.

liangyuanpeng commented 2 months ago

I'm interested in this and I want to take care of Clean up the uid labels on the resource And do we plan to issue deprecation warnings to users before removing logic?

XiShanYongYe-Chang commented 2 months ago

I'm interested in this and I want to take care of Clean up the uid labels on the resource.

Thanks a lot~

And do we plan to issue deprecation warnings to users before removing logic?

I think it is necessary, although we have mentioned the need to discard these labels in many community meetings and related issue descriptions and discussions, we still need to find a clear place to describe the text, so that this information can be passed to more users.

Do you have any suggestions?

XiShanYongYe-Chang commented 2 months ago

/help Anyone interested can pick up the task to develop.

karmada-bot commented 2 months ago

@XiShanYongYe-Chang: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/karmada-io/karmada/issues/4711): >/help >Anyone interested can pick up the task to develop. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
whitewindmills commented 2 months ago

I wanna pick up this one Clean up namespace/name labels on resources.

XiShanYongYe-Chang commented 2 months ago

I wanna pick up this one Clean up namespace/name labels on resources.

Ok, thx~

liangyuanpeng commented 2 months ago

I think it is necessary, although we have mentioned the need to discard these labels in many community meetings and related issue descriptions and discussions, we still need to find a clear place to describe the text, so that this information can be passed to more users. Do you have any suggestions?

Is FeatureGates enough? At least it gives users a chance to be compatible., like :


  //**TODO GA in 1.11, delete the FeatureGate**
 if !FeatureGates.xxx.enabled {
        // TODO: Delete following two lines in release-1.9
    delete(bindingCopy.Labels, workv1alpha2.ResourceBindingUIDLabel)
    delete(bindingCopy.Labels, policyv1alpha1.PropagationPolicyUIDLabel)
 }

cc @chaunceyjiang

yizhang-zen commented 1 month ago

@chaunceyjiang , it seems all the tasks have been picked up. Any input from you and any work that need us?

XiShanYongYe-Chang commented 1 month ago

/assign @liangyuanpeng @whitewindmills @XiShanYongYe-Chang