Open XiShanYongYe-Chang opened 2 months ago
I'm interested in this and I want to take care of Clean up the uid labels on the resource
And do we plan to issue deprecation warnings to users before removing logic?
I'm interested in this and I want to take care of Clean up the uid labels on the resource.
Thanks a lot~
And do we plan to issue deprecation warnings to users before removing logic?
I think it is necessary, although we have mentioned the need to discard these labels in many community meetings and related issue descriptions and discussions, we still need to find a clear place to describe the text, so that this information can be passed to more users.
Do you have any suggestions?
/help Anyone interested can pick up the task to develop.
@XiShanYongYe-Chang: This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help
command.
I wanna pick up this one Clean up namespace/name labels on resources
.
I wanna pick up this one
Clean up namespace/name labels on resources
.
Ok, thx~
I think it is necessary, although we have mentioned the need to discard these labels in many community meetings and related issue descriptions and discussions, we still need to find a clear place to describe the text, so that this information can be passed to more users. Do you have any suggestions?
Is FeatureGates enough? At least it gives users a chance to be compatible., like :
//**TODO GA in 1.11, delete the FeatureGate**
if !FeatureGates.xxx.enabled {
// TODO: Delete following two lines in release-1.9
delete(bindingCopy.Labels, workv1alpha2.ResourceBindingUIDLabel)
delete(bindingCopy.Labels, policyv1alpha1.PropagationPolicyUIDLabel)
}
cc @chaunceyjiang
@chaunceyjiang , it seems all the tasks have been picked up. Any input from you and any work that need us?
/assign @liangyuanpeng @whitewindmills @XiShanYongYe-Chang
What would you like to be added:
Please ref to https://github.com/karmada-io/karmada/issues/4683#issuecomment-1996604867
Why is this needed:
Continue the work of #4000 and break down the tasks to be done.
permanent-id
labels toPropagationPolicy/ClusterPropagationPolicy
,ResourceBinding/ClusterResourceBinding
, andWork
resources inkarmada-webhook
.permanent-id
for pp, cpp, rb, crb, work in the karmada-webhook @jwcesign @XiShanYongYe-Chang #4474permanent-id
logic in the karmada-controller-manager (we can do it in the next release) @whitewindmillsnamespace/name
labels in the code withpermanent-id
labels, including: @whitewindmills @XiShanYongYe-Changpropagationpolicy.karmada.io/namespace
,propagationpolicy.karmada.io/name
->propagationpolicy.karmada.io/permanent-id
#4743clusterpropagationpolicy.karmada.io/name
->clusterpropagationpolicy.karmada.io/permanent-id
#4743resourcebinding.karmada.io/key
->resourcebinding.karmada.io/permanent-id
#4811clusterresourcebinding.karmada.io/key
->clusterresourcebinding.karmada.io/permanent-id
#4811work.karmada.io/namespace
,work.karmada.io/name
->work.karmada.io/permanent-id
#4813 #4765 #4865uid
labels on the resource: @liangyuanpeng #4718propagationpolicy.karmada.io/uid
clusterpropagationpolicy.karmada.io/uid
resourcebinding.karmada.io/uid
clusterresourcebinding.karmada.io/uid
work.karmada.io/uid
namespace/name
labels on resources: @whitewindmillspropagationpolicy.karmada.io/namespace
#4743propagationpolicy.karmada.io/name
#4743clusterpropagationpolicy.karmada.io/name
#4743resourcebinding.karmada.io/key
#4811clusterresourcebinding.karmada.io/key
#4811work.karmada.io/namespace
#4813work.karmada.io/name
#4813propagationpolicy.karmada.io/namespace
,propagationpolicy.karmada.io/name