Closed liangyuanpeng closed 1 month ago
/assign @RainbowMango
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.76%. Comparing base (
ff7322a
) to head (b825b35
). Report is 38 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
https://github.com/github/codeql-action/pull/435#issuecomment-810350417 Although perhaps you could add "Uploading code scanning results requires write access." as second sentence?
I found the PR for this warnning log and seems like it just wanted to draw people's attention to the fact that this requires write permissions.
So just add permission for this workflow to resolve it, keeping on push event to trigger it.
PTAL,Thanks. /cc zhzhuang-zju @RainbowMango
And it's verifyed on my fork repo, check https://github.com/liangyuanpeng/karmada/actions/runs/8518835905/job/23331711824?pr=53
I found the PR for this warnning log and seems like it just wanted to draw people's attention to the fact that this requires write permissions.
@liangyuanpeng Thanks for your work! This warning log is indeed very confusing. Since it's just a permissions issue, I think your change is appropriate.
PTAL,Thanks.
@RainbowMango @zhzhuang-zju
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup What this PR does / why we need it:
PartOf https://github.com/karmada-io/karmada/issues/4761
skip the push event for dependabot
Which issue(s) this PR fixes: Fixes #4761
Special notes for your reviewer:
Does this PR introduce a user-facing change?: