karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 812 forks source link

add e2e test for deployment replicas syncer #4764

Closed chaosi-zju closed 1 month ago

chaosi-zju commented 1 month ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Resubmit the PR #4716.

Due to the bug of #4758, this e2e PR was reverted to avoid the long-term failure of e2e.

Now, the bug has been fixed, resubmit this e2e PR again.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chaosi-zju commented 1 month ago

ping @XiShanYongYe-Chang

XiShanYongYe-Chang commented 1 month ago

/assign

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.77%. Comparing base (ff7322a) to head (8b9e1e2).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4764 +/- ## ========================================== - Coverage 51.79% 51.77% -0.03% ========================================== Files 250 250 Lines 24991 24991 ========================================== - Hits 12945 12940 -5 - Misses 11337 11341 +4 - Partials 709 710 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4764/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.77% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment