Closed XiShanYongYe-Chang closed 1 month ago
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 51.78%. Comparing base (
ff7322a
) to head (0e60af8
).
Files | Patch % | Lines |
---|---|---|
pkg/controllers/binding/common.go | 50.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thank you @XiShanYongYe-Chang 🏆 We'll give this a try over the next day or two
We'll give this a try over the next day or two
Looking forward to your feedback :)
Confirm the change fixes our issue on sync failure for resource name > 63 chars. Thanks, team! ❤️
What type of PR is this?
/kind bug
What this PR does / why we need it:
Karmada will generate the work namespace/name labels on the resources propagated to member clusters:
When the created resource name is longer than 63 characters, those labels will cause the resource to fail to be created successfully in the member cluster.
So we need to remove those labels from resources propagated to member clusters.
Which issue(s) this PR fixes: Fixes #4683
Special notes for your reviewer:
Does this PR introduce a user-facing change?: