karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Automated cherry pick of #4751: fix wrong annotation marks on resource #4771

Closed XiShanYongYe-Chang closed 1 month ago

XiShanYongYe-Chang commented 1 month ago

Cherry pick of #4751 on release-1.8.

4751: fix wrong annotation marks on resource

For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed incorrect annotation markup when policy preemption occurs.
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 51.77%. Comparing base (eec084e) to head (d585366).

Files Patch % Lines
pkg/detector/detector.go 0.00% 1 Missing :warning:
pkg/util/helper/work.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.8 #4771 +/- ## =============================================== - Coverage 51.79% 51.77% -0.03% =============================================== Files 243 243 Lines 24117 24117 =============================================== - Hits 12491 12486 -5 - Misses 10944 10948 +4 - Partials 682 683 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4771/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4771/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.77% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/release-1.8/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment