karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

fix bug of wrong delete endpointslice collect from member cluster #4774

Closed XiShanYongYe-Chang closed 1 month ago

XiShanYongYe-Chang commented 1 month ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

The last few CI runs have been failing frequently, for example: https://github.com/karmada-io/karmada/actions/runs/8463439534/job/23186473124

Through analysis, it is found that a bug was introduced in #4737, which will cause when creating another new ServiceEport, it will mistakenly delete the endpointslice that collected by other ServiceExports.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.77%. Comparing base (ff7322a) to head (3121bd9). Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4774 +/- ## ========================================== - Coverage 51.79% 51.77% -0.02% ========================================== Files 250 250 Lines 24991 24989 -2 ========================================== - Hits 12945 12939 -6 - Misses 11337 11340 +3 - Partials 709 710 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4774/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4774/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.77% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 month ago

/cc @RainbowMango @chaunceyjiang

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/controllers/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment