Closed XiShanYongYe-Chang closed 1 month ago
Attention: Patch coverage is 0%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 51.77%. Comparing base (
4e25482
) to head (e511ad7
).
Files | Patch % | Lines |
---|---|---|
pkg/util/helper/work.go | 0.00% | 2 Missing :warning: |
pkg/detector/detector.go | 0.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you help take a look again @whitewindmills @RainbowMango ?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Learn from #4751, to avoid ambiguity and to be consistent with the Annotation naming convention:
https://github.com/karmada-io/karmada/blob/57c1989667d826864aa09105daa04434e2c75dd9/pkg/util/annotation.go#L29-L51
remove old MergeAnnotation func and rename ReplaceAnnotation to MergeAnnotation.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: