karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

remove old MergeAnnotation func and rename ReplaceAnnotation to MergeAnnotation #4776

Closed XiShanYongYe-Chang closed 1 month ago

XiShanYongYe-Chang commented 1 month ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Learn from #4751, to avoid ambiguity and to be consistent with the Annotation naming convention:

https://github.com/karmada-io/karmada/blob/57c1989667d826864aa09105daa04434e2c75dd9/pkg/util/annotation.go#L29-L51

remove old MergeAnnotation func and rename ReplaceAnnotation to MergeAnnotation.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 51.77%. Comparing base (4e25482) to head (e511ad7).

Files Patch % Lines
pkg/util/helper/work.go 0.00% 2 Missing :warning:
pkg/detector/detector.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4776 +/- ## ========================================== - Coverage 51.78% 51.77% -0.02% ========================================== Files 250 250 Lines 24989 24980 -9 ========================================== - Hits 12941 12933 -8 + Misses 11339 11338 -1 Partials 709 709 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.77% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 month ago

Can you help take a look again @whitewindmills @RainbowMango ?

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment