karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Fixe invalid kubebuilder marker, that makes pinned plural name does not work. #4777

Closed RainbowMango closed 1 month ago

RainbowMango commented 1 month ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

When configuring CRD naming and scope the valid marker should be the format +kubebuilder:resource:xxx, but the operator mistakenly marked +kubebuilder:xxx, which makes the mark doesn't work.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

I found this during updating the controller-tools to v0.12.0+, and I found the plural name of Operator changed to Karmada instead of Karmadas. That means the pinned plural name not work.

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.77%. Comparing base (4e25482) to head (8b9d86d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4777 +/- ## ========================================== - Coverage 51.78% 51.77% -0.01% ========================================== Files 250 250 Lines 24989 24989 ========================================== - Hits 12941 12939 -2 - Misses 11339 11340 +1 - Partials 709 710 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4777/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4777/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.77% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 1 month ago

/assign @calvin0327

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[charts/OWNERS](https://github.com/karmada-io/karmada/blob/master/charts/OWNERS)** - **[operator/OWNERS](https://github.com/karmada-io/karmada/blob/master/operator/OWNERS)** - **[operator/pkg/apis/OWNERS](https://github.com/karmada-io/karmada/blob/master/operator/pkg/apis/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment