Closed RainbowMango closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.77%. Comparing base (
4e25482
) to head (8b9d86d
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/assign @calvin0327
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When configuring CRD naming and scope the valid marker should be the format
+kubebuilder:resource:xxx
, but the operator mistakenly marked+kubebuilder:xxx
, which makes the mark doesn't work.Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
I found this during updating the controller-tools to v0.12.0+, and I found the plural name of Operator changed to
Karmada
instead ofKarmadas
. That means the pinned plural name not work.Does this PR introduce a user-facing change?: