Closed RainbowMango closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.78%. Comparing base (
4e25482
) to head (32a4076
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup
What this PR does / why we need it: When the controller-tools generate the CRDs, it guesses the plural name by github.com/gobuffalo/flect if the plural name is not explicitly specified.
But the rule of generating plural names might change over different github.com/gobuffalo/flect versions. See https://github.com/kubernetes-sigs/controller-tools/pull/804#discussion_r1178098768 for an example.
So, this PR pin plural name for all APIs to avoid this unexpected change. (We don't depend on github.com/gobuffalo/flect, but the controller-tools reply on it. We might update controller-tools.) Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
I'm trying to update the controller-tools but found the plural name of Karmada operator changed unexpectedly(see the fix at #4777), that reminds me we'd better pin the plural name.
Does this PR introduce a user-facing change?: