karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Pin plural name for all APIs to avoid unexpected change #4778

Closed RainbowMango closed 1 month ago

RainbowMango commented 1 month ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it: When the controller-tools generate the CRDs, it guesses the plural name by github.com/gobuffalo/flect if the plural name is not explicitly specified.

But the rule of generating plural names might change over different github.com/gobuffalo/flect versions. See https://github.com/kubernetes-sigs/controller-tools/pull/804#discussion_r1178098768 for an example.

So, this PR pin plural name for all APIs to avoid this unexpected change. (We don't depend on github.com/gobuffalo/flect, but the controller-tools reply on it. We might update controller-tools.) Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

I'm trying to update the controller-tools but found the plural name of Karmada operator changed unexpectedly(see the fix at #4777), that reminds me we'd better pin the plural name.

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.78%. Comparing base (4e25482) to head (32a4076).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4778 +/- ## ========================================== - Coverage 51.78% 51.78% -0.01% ========================================== Files 250 250 Lines 24989 24989 ========================================== - Hits 12941 12940 -1 - Misses 11339 11340 +1 Partials 709 709 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4778/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4778/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.78% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment