karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Corrected poll timeout example #4783

Closed Jay179-sudo closed 1 month ago

Jay179-sudo commented 1 month ago

What type of PR is this?

This PR corrects a small documentation error. /kind documentation

What this PR does / why we need it:

Fixes small documentation errors.

Which issue(s) this PR fixes: Fixes #4775

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

NONE
karmada-bot commented 1 month ago

Welcome @Jay179-sudo! It looks like this is your first PR to karmada-io/karmada 🎉

Jay179-sudo commented 1 month ago

/assign @xishanyongye-chang Looking forward to more!

XiShanYongYe-Chang commented 1 month ago

@Jay179-sudo Thanks~ Ask @RainbowMango to help run the CI. /cc @RainbowMango

RainbowMango commented 1 month ago

Ask @RainbowMango to help run the CI.

Done.

/approve

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, Vacant2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.76%. Comparing base (6534ffb) to head (deaf341).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4783 +/- ## ======================================= Coverage 51.76% 51.76% ======================================= Files 250 250 Lines 24980 24980 ======================================= Hits 12930 12930 Misses 11340 11340 Partials 710 710 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4783/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4783/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.76% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.