karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

labels cannot be deleted via Karmada propagation #4784

Closed whitewindmills closed 1 month ago

whitewindmills commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #4781

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: Fix the problem that labels cannot be deleted via Karmada propagation.
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.77%. Comparing base (6534ffb) to head (ce84edf).

Files Patch % Lines
pkg/util/helper/work.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4784 +/- ## ========================================== + Coverage 51.76% 51.77% +0.01% ========================================== Files 250 250 Lines 24980 24980 ========================================== + Hits 12930 12933 +3 + Misses 11340 11338 -2 + Partials 710 709 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4784/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4784/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.77% <80.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 month ago

Thanks~ /assign

XiShanYongYe-Chang commented 1 month ago

@whitewindmills can you help add the release-note?

whitewindmills commented 1 month ago

@XiShanYongYe-Chang done.

XiShanYongYe-Chang commented 1 month ago

/assign @RainbowMango

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/util/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/util/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment