karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Extend the API field orphaningDeletion to prevent removal managed resources #4788

Open CharlesQQ opened 1 month ago

CharlesQQ commented 1 month ago

What type of PR is this?

What this PR does / why we need it: Extend the API field orphaningDeletion to prevent removal managed resources

Which issue(s) this PR fixes: Fixes https://github.com/karmada-io/karmada/issues/4709

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign rainbowmango after the PR has been reviewed. You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 53.08%. Comparing base (c6ccb99) to head (ed29102).

Files Patch % Lines
pkg/detector/detector.go 0.00% 9 Missing :warning:
pkg/controllers/binding/binding_controller.go 0.00% 4 Missing :warning:
pkg/controllers/binding/common.go 50.00% 2 Missing :warning:
pkg/util/helper/work.go 0.00% 2 Missing :warning:
...controllers/unifiedauth/unified_auth_controller.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4788 +/- ## ========================================== + Coverage 53.06% 53.08% +0.02% ========================================== Files 251 251 Lines 20387 20409 +22 ========================================== + Hits 10819 10835 +16 - Misses 8855 8860 +5 - Partials 713 714 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4788/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4788/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.08% <45.45%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 week ago

/kind feature