Closed whitewindmills closed 1 month ago
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 51.76%. Comparing base (
a0c0a98
) to head (9c08138
).
Files | Patch % | Lines |
---|---|---|
pkg/util/helper/work.go | 0.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @XiShanYongYe-Chang @chaunceyjiang
Did you discover the problem during development?
Yes, this causes CI to always fail.
Another PR https://github.com/karmada-io/karmada/pull/4743 still needs this, could you take look? /cc @RainbowMango
Hi @whitewindmills, how about adding the release note, I think we should cherry-pick this patch to the previous branch, how do you think?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind bug
What this PR does / why we need it: Since labels will be overwritten every time they are updated and created, this causes
work.karmada.io/permanent-id
to constantly change. I add some debug logs in karmada-webhook to capture the bug:Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: