karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Automated cherry pick of #4784: labels cannot be deleted via Karmada propagation #4797

Closed whitewindmills closed 1 month ago

whitewindmills commented 1 month ago

Cherry pick of #4784 on release-1.9.

4784: labels cannot be deleted via Karmada propagation

For details on the cherry pick process, see the cherry pick requests page.

karmada-controller-manager: Fix the problem that labels cannot be deleted via Karmada propagation.
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.44%. Comparing base (4e34fdc) to head (ac060ab).

Files Patch % Lines
pkg/util/helper/work.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.9 #4797 +/- ## =============================================== - Coverage 51.46% 51.44% -0.03% =============================================== Files 250 250 Lines 24952 24952 =============================================== - Hits 12842 12837 -5 - Misses 11404 11408 +4 - Partials 706 707 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4797/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4797/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.44% <80.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/util/OWNERS](https://github.com/karmada-io/karmada/blob/release-1.9/pkg/util/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment