karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Rename a function to match with updated behavior #4800

Closed yizhang-zen closed 3 weeks ago

yizhang-zen commented 4 weeks ago

Follow up the comment

cc @XiShanYongYe-Chang

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.76%. Comparing base (b0da31a) to head (81efad9).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4800 +/- ## ========================================== - Coverage 51.77% 51.76% -0.01% ========================================== Files 250 250 Lines 24980 24980 ========================================== - Hits 12933 12931 -2 - Misses 11338 11340 +2 Partials 709 709 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4800/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4800/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `51.76% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/controllers/OWNERS)~~ [XiShanYongYe-Chang,chaunceyjiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chaunceyjiang commented 3 weeks ago

https://github.com/karmada-io/karmada/pull/4800/checks?check_run_id=23415296778

You need to sign your commit. @yizhang-zen

RainbowMango commented 3 weeks ago

/lgtm

Yeah, waiting for the DCO, then ready to go.

XiShanYongYe-Chang commented 3 weeks ago

Kindly ping @yizhang-zen

RainbowMango commented 3 weeks ago

/lgtm