karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

feat/karmadactl: extra etcd support without cert. #4801

Open liangyuanpeng opened 4 weeks ago

liangyuanpeng commented 4 weeks ago

What type of PR is this?

/kind feature What this PR does / why we need it:

I'm using karmadactl to deploy karmada and i will get the error when i only set the external-etcd-servers without certificate.

So this PR is working for support without certificate for external etcd when using karmadactl to init karmada.

I can without the certificate of etcd when I use kubeadm to configure external etcd, so I want to get the same experience here.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kramadactl: extra etcd support without cert now.
karmada-bot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from liangyuanpeng and additionally assign lfbear, prodanlabs after the PR has been reviewed. You can assign the PR to them by writing /assign @lfbear @prodanlabs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[.github/workflows/OWNERS](https://github.com/karmada-io/karmada/blob/master/.github/workflows/OWNERS)** - **[hack/OWNERS](https://github.com/karmada-io/karmada/blob/master/hack/OWNERS)** - **[pkg/karmadactl/cmdinit/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/cmdinit/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (b0da31a) to head (066ab43). Report is 50 commits behind head on master.

Files Patch % Lines
pkg/karmadactl/cmdinit/kubernetes/deploy.go 33.33% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4801 +/- ## ========================================== + Coverage 51.77% 53.11% +1.34% ========================================== Files 250 250 Lines 24980 20358 -4622 ========================================== - Hits 12933 10813 -2120 + Misses 11338 8827 -2511 - Partials 709 718 +9 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4801/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.11% <71.42%> (+1.34%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 3 weeks ago

Can you briefly describe what this PR does and why we need it?

liangyuanpeng commented 3 weeks ago

Absolutely, i update the describe of PR.

PTAL ,Thanks.

liangyuanpeng commented 3 weeks ago

also cc @tedli for review.

liangyuanpeng commented 2 weeks ago

@zhzhuang-zju PTAL