Open liangyuanpeng opened 4 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from liangyuanpeng and additionally assign lfbear, prodanlabs after the PR has been reviewed.
You can assign the PR to them by writing /assign @lfbear @prodanlabs
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Attention: Patch coverage is 71.42857%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 53.11%. Comparing base (
b0da31a
) to head (066ab43
). Report is 50 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/karmadactl/cmdinit/kubernetes/deploy.go | 33.33% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you briefly describe what this PR does and why we need it?
Absolutely, i update the describe of PR.
PTAL ,Thanks.
also cc @tedli for review.
@zhzhuang-zju PTAL
What type of PR is this?
/kind feature What this PR does / why we need it:
I'm using karmadactl to deploy karmada and i will get the error when i only set the
external-etcd-servers
without certificate.So this PR is working for support without certificate for external etcd when using karmadactl to init karmada.
I can without the certificate of etcd when I use
kubeadm
to configure external etcd, so I want to get the same experience here.Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: