Closed hulizhe closed 2 weeks ago
Welcome @hulizhe! It looks like this is your first PR to karmada-io/karmada 🎉
/assign @chaosi-zju
this PR is modified upon #4740, the review can wait until this PR is merged in.
Hi @hulizhe, #4740 has been merged, this PR can go on.
Hi @hulizhe, #4740 has been merged, this PR can go on.
done, thanks for the reminder
/LGTM
you did great job, thank you for your efffort !
/lgtm cc @XiShanYongYe-Chang
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.11%. Comparing base (
4898c0f
) to head (e62c659
). Report is 20 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@XiShanYongYe-Chang @zhzhuang-zju @chaosi-zju @chaunceyjiang Thanks for the code review, it helped me a lot!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind failing-test
What this PR does / why we need it: add e2e test for lazy propagation policy
Involving:
Simple Case 3 (Lazy to immediate) Simple Case 4 (Immediate to lazy) Combined Case 4 (Policy preemption) Which issue(s) this PR fixes: part of #4607
Special notes for your reviewer:
Does this PR introduce a user-facing change?: