karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

add e2e test for lazy propagation policy #4804

Closed hulizhe closed 2 weeks ago

hulizhe commented 3 weeks ago

What type of PR is this? /kind failing-test

What this PR does / why we need it: add e2e test for lazy propagation policy

Involving:

Simple Case 3 (Lazy to immediate) Simple Case 4 (Immediate to lazy) Combined Case 4 (Policy preemption) Which issue(s) this PR fixes: part of #4607

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-bot commented 3 weeks ago

Welcome @hulizhe! It looks like this is your first PR to karmada-io/karmada 🎉

XiShanYongYe-Chang commented 3 weeks ago

/assign @chaosi-zju

chaosi-zju commented 3 weeks ago

this PR is modified upon #4740, the review can wait until this PR is merged in.

XiShanYongYe-Chang commented 3 weeks ago

Hi @hulizhe, #4740 has been merged, this PR can go on.

hulizhe commented 3 weeks ago

Hi @hulizhe, #4740 has been merged, this PR can go on.

done, thanks for the reminder

chaosi-zju commented 2 weeks ago

/LGTM

you did great job, thank you for your efffort !

zhzhuang-zju commented 2 weeks ago

/lgtm cc @XiShanYongYe-Chang

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.11%. Comparing base (4898c0f) to head (e62c659). Report is 20 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4804 +/- ## ========================================== + Coverage 51.75% 53.11% +1.35% ========================================== Files 250 250 Lines 24964 20351 -4613 ========================================== - Hits 12920 10809 -2111 + Misses 11335 8825 -2510 - Partials 709 717 +8 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4804/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.11% <ø> (+1.35%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hulizhe commented 2 weeks ago

@XiShanYongYe-Chang @zhzhuang-zju @chaosi-zju @chaunceyjiang Thanks for the code review, it helped me a lot!

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment