karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Deprecate key labels of rb/crb #4811

Closed whitewindmills closed 3 weeks ago

whitewindmills commented 3 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it:

resourcebinding.karmada.io/key -> resourcebinding.karmada.io/permanent-id
clusterresourcebinding.karmada.io/key -> clusterresourcebinding.karmada.io/permanent-id

Which issue(s) this PR fixes: part of https://github.com/karmada-io/karmada/issues/4711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: The labels `resourcebinding.karmada.io/key` and `clusterresourcebinding.karmada.io/key` has been deprecated and not be populated in Work objects(replaced by `resourcebinding.karmada.io/permanent-id` and `clusterresourcebinding.karmada.io/permanent-id` respectively).
whitewindmills commented 3 weeks ago

Split from https://github.com/karmada-io/karmada/pull/4743. /cc @RainbowMango

RainbowMango commented 3 weeks ago

Split from #4743. /cc @RainbowMango

Nice, I like small PRs. Thanks. I'll work on this then #4743.

RainbowMango commented 3 weeks ago

Re-run the test as the failure seems not related:

Error: operator/pkg/util/util.go:20:2: read /opt/hostedtoolcache/go/1.21.8/x64/src/archive/tar/example_test.go: unexpected NUL in input

XiShanYongYe-Chang commented 3 weeks ago

/assign

RainbowMango commented 3 weeks ago

I updated the release notes a little bit, by the way.

karmada-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RainbowMango commented 3 weeks ago

What's the next PR I can help with?

whitewindmills commented 3 weeks ago

What's the next PR I can help with?

thanks, https://github.com/karmada-io/karmada/pull/4743 still needs your review.

RainbowMango commented 3 weeks ago

Got it.