Closed whitewindmills closed 4 days ago
Split from https://github.com/karmada-io/karmada/pull/4743. /cc @RainbowMango
@XiShanYongYe-Chang PTAL~
/assign
~Do we also need to be clear about the labels here:~
I submit a pr to fix this: #4865
Attention: Patch coverage is 66.66667%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 53.07%. Comparing base (
8f9a624
) to head (8328054
). Report is 4 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/controllers/status/work_status_controller.go | 63.63% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@RainbowMango @XiShanYongYe-Chang can we safely remove this file? since it won't be used. https://github.com/karmada-io/karmada/blob/a57ca7ef06b455bd4e1dc3dd9b0f97772419e5e1/pkg/apis/work/v1alpha1/well_known_constants.go#L1-L25
can we safely remove this file? since it won't be used.
The file is empty. I think we can remove it.
Please continue to help review this PR. /cc @RainbowMango
OK, thanks. will do ASAP.
This PR focuses on removing labels(work.karmada.io/namespace
, work.karmada.io/name
) from the codebase, right?
This PR focuses on removing labels(work.karmada.io/namespace, work.karmada.io/name) from the codebase, right?
yes
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: part of https://github.com/karmada-io/karmada/issues/4711
Special notes for your reviewer:
Does this PR introduce a user-facing change?: