search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Use RetryOnConflict for applying CRB #4814

Closed whitewindmills closed 3 weeks ago

whitewindmills commented 3 weeks ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: When creating or updating CRB, we should use the func retry.RetryOnConflict, that keeps same with RB.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
whitewindmills commented 3 weeks ago

/cc @XiShanYongYe-Chang @RainbowMango

karmada-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment