karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration

https://karmada.io

Apache License 2.0

4.12k stars 807 forks source link

Add image-pull-policy flag for karmada init cmd #4815

Closed XiShanYongYe-Chang closed 3 weeks ago

XiShanYongYe-Chang commented 3 weeks ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

4789

Which issue(s) this PR fixes: Part of #4789

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Introduced `--image-pull-policy` flag to the `init` command, which will be used to specify the image pull policy of all components.

XiShanYongYe-Chang commented 3 weeks ago

/cc @RainbowMango

RainbowMango commented 3 weeks ago

/assign

karmada-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/karmadactl/cmdinit/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/cmdinit/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

XiShanYongYe-Chang commented 3 weeks ago

The UT failed, I pushed it again. @RainbowMango