search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Fix the bug of mcs binding losing resourcebinding.karmada.io/permanent-id label #4818

Closed whitewindmills closed 3 weeks ago

whitewindmills commented 3 weeks ago

What type of PR is this? /kind bug

What this PR does / why we need it: The label resourcebinding.karmada.io/permanent-id of mcs binding may be lost when updating, the reason is similar to https://github.com/karmada-io/karmada/pull/4793. lx_clip1712658406437

After fixing

image

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Fixed the bug of mcs binding losing resourcebinding.karmada.io/permanent-id label.
whitewindmills commented 3 weeks ago

/cc @XiShanYongYe-Chang @RainbowMango

XiShanYongYe-Chang commented 3 weeks ago

Thanks @whitewindmills Do we have similar processing logic elsewhere?

whitewindmills commented 3 weeks ago

Do we have similar processing logic elsewhere?

After global search, this is the last place.

karmada-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/controllers/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment