chore: remove unuse ghaction step and collect logs of karmadactl test.

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration

https://karmada.io

Apache License 2.0

4.12k stars 807 forks source link

chore: remove unuse ghaction step and collect logs of karmadactl test. #4824

Open liangyuanpeng opened 3 weeks ago

liangyuanpeng commented 3 weeks ago

What type of PR is this?

What this PR does / why we need it: /kind cleanup

this CI is using the kubernetes from created by cli-testing-environment and have not used helm/kind-action, so juse remove it..

https://github.com/karmada-io/karmada/blob/4898c0fc55a13033fcf21fcc46a41318548c5713/hack/cli-testing-environment.sh#L53-L55

the second change is collect logs for kind kubernetes.

/assign @RainbowMango

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

RainbowMango commented 2 weeks ago

@zhzhuang-zju Please take a look

zhzhuang-zju commented 2 weeks ago

/assign

zhzhuang-zju commented 2 weeks ago

@liangyuanpeng This PR consists of two parts actually as you mentioned in the PR description:

remove step helm/kind-action Just as you said, this CI is using the kubernetes from created by cli-testing-environment, so step kind-action can be removed. But I have two questions.
1. When was kind installed on the environment, I don't find anywhere in cli-testing-environment where kind is installed, am I missing it?
2. How did you find this? I mean, "kind-action" isn't used, but it shouldn't have an effect on workflow and is hard to detect.
collect logs for kind kubernetes I‘m okay with this part.

BTW, thanks for this commit~

liangyuanpeng commented 2 weeks ago

When was kind installed on the environment, I don't find anywhere in cli-testing-environment where kind is installed, am I missing it?

Good catch! seems like it's provided by github action or some github action cache. i will update the cli-testing-environment.sh to check and install the command of kind.

How did you find this? I mean, "kind-action" isn't used, but it shouldn't have an effect on workflow and is hard to detect.

I am wroting the code for https://github.com/karmada-io/karmada/pull/4801 and I was not satisfied with the workflow. He increased the number of parallel runs of the action, so i more research this workflow and found it.

@zhzhuang-zju

liangyuanpeng commented 2 weeks ago

In the next PR, I will continue to update this workflow, use one action to build the image and karmadactl, and then test it in other actions, CI workflow is the same thing, and let's talk about it in other space.

zhzhuang-zju commented 2 weeks ago

use one action to build the image and karmadactl

There seems to have been a discussion about it before，https://github.com/karmada-io/karmada/pull/3168#discussion_r1129052862 @RainbowMango

In the next PR, I will continue to update this workflow

Very welcome. If you make any progress, please ping me~

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from rainbowmango after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[.github/workflows/OWNERS](https://github.com/karmada-io/karmada/blob/master/.github/workflows/OWNERS)** - **[hack/OWNERS](https://github.com/karmada-io/karmada/blob/master/hack/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment