Closed wangxf1987 closed 6 days ago
Welcome @wangxf1987! It looks like this is your first PR to karmada-io/karmada 🎉
Is this related to #4823 ?
Is this related to #4823 ?
not related
@RainbowMango I want to contribute our resource interperter, it name is fed.jd.com/v1/KService, which is equivalent to apps.kruise.io. It it possible?
Do you mean to put fed.jd.com/v1/KService
under the thirdparty resourcecustomizations?
As far as I know, the third-party customizations are designed for those well-known open-sourced resource types.
Is the fed.jd.com/v1/KService
open-sourced?
Do you mean to put
fed.jd.com/v1/KService
under the thirdparty resourcecustomizations?As far as I know, the third-party customizations are designed for those well-known open-sourced resource types. Is the
fed.jd.com/v1/KService
open-sourced?
open will be soon
Do you mean to put
fed.jd.com/v1/KService
under the thirdparty resourcecustomizations?As far as I know, the third-party customizations are designed for those well-known open-sourced resource types. Is the
fed.jd.com/v1/KService
open-sourced?
we have an plan in the jdcloud, and open the kservice project
we have an plan in the jdcloud, and open the kservice project
Nice. Please talk to me then.
add the opts.ResyncPeriod in the controller-manager, I not found the NotSync issue. it's should be consider to accpet the PR?
add the opts.ResyncPeriod in the controller-manager, I not found the NotSync issue. it's should be consider to accpet the PR? @RainbowMango
/assign
I'll look at it. But I'm curious why you need this. Using resync to solve problems might not be a recommended pattern.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.05%. Comparing base (
40d65f9
) to head (3232c52
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@wangxf1987 Xiaofei, this PR contains a merge commit that is not what we want. Could you please rebase your PR, you can find the guidelines at https://karmada.io/docs/next/contributor/github-workflow.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks~ /lgtm
I talked to @wangxf1987, this PR isn't for fixing anything, just a cleanup. /kind cleanup
…actory
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: