karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

karmadactl: add common code for create and wait deployments. #4828

Closed liangyuanpeng closed 6 days ago

liangyuanpeng commented 2 weeks ago

What type of PR is this?

What this PR does / why we need it: /kind cleanup

cc @zhzhuang-zju

Add the common code for karmadactl create deployment.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

liangyuanpeng commented 2 weeks ago

@zhzhuang-zju

fixed the comment, PTAL,Thanks.

zhzhuang-zju commented 2 weeks ago

/lgtm cc @RainbowMango

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (da7689f) to head (e8aefe0). Report is 22 commits behind head on master.

Files Patch % Lines
pkg/karmadactl/cmdinit/kubernetes/deploy.go 0.00% 0 Missing and 6 partials :warning:
pkg/karmadactl/cmdinit/utils/deploy.go 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4828 +/- ## ========================================== + Coverage 51.77% 53.11% +1.34% ========================================== Files 250 251 +1 Lines 24985 20342 -4643 ========================================== - Hits 12935 10805 -2130 + Misses 11337 8825 -2512 + Partials 713 712 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4828/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4828/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.11% <0.00%> (+1.34%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 2 weeks ago

/approve

Leave LGTM to @chaunceyjiang

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/karmadactl/cmdinit/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/cmdinit/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment