Closed liangyuanpeng closed 6 days ago
@zhzhuang-zju
fixed the comment, PTAL,Thanks.
/lgtm cc @RainbowMango
Attention: Patch coverage is 0%
with 10 lines
in your changes are missing coverage. Please review.
Project coverage is 53.11%. Comparing base (
da7689f
) to head (e8aefe0
). Report is 22 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/karmadactl/cmdinit/kubernetes/deploy.go | 0.00% | 0 Missing and 6 partials :warning: |
pkg/karmadactl/cmdinit/utils/deploy.go | 0.00% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/approve
Leave LGTM to @chaunceyjiang
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
What this PR does / why we need it: /kind cleanup
cc @zhzhuang-zju
Add the common code for karmadactl create deployment.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: