karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

feat: upgrade karmada chart dependency #4829

Closed warjiang closed 2 weeks ago

warjiang commented 2 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it: upgrade bitnami/common dependency in karmada chart Which issue(s) this PR fixes: no related issue, but as part of another pr https://github.com/karmada-io/karmada/pull/4785 in this pr, we combine all image secrets together, this is reduce similar code like :

{{/*
Return the proper Docker Image Registry Secret Names
*/}}
{{- define "karmada.agent.imagePullSecrets" -}}
{{ include "common.images.pullSecrets" (dict "images" (list .Values.agent.image) "global" .Values.global) }}
{{- end -}}

but this is introduce another problem, bitnami/common@1.x.x will not handle duplicate secret names in chart, after upgrade it to bitnami/common@2.x.x, it will use uniq to remove duplicate secret names in chart.

more details can refer 👉: https://github.com/bitnami/charts/commit/ddfea70831875639cb298a555ad6dd5e68f059e4

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

upgrade `bitnami/common` dependency in karmada chart from `1.x.x` to `2.x.x`
warjiang commented 2 weeks ago

/assign @pidb @Poor12

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[charts/OWNERS](https://github.com/karmada-io/karmada/blob/master/charts/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment