karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Add finalizer for propagation policy #4836

Closed whitewindmills closed 2 weeks ago

whitewindmills commented 2 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it: See https://github.com/karmada-io/karmada/pull/4743#discussion_r1560637648 Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
whitewindmills commented 2 weeks ago

/cc @RainbowMango to take a look.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 53.07%. Comparing base (fdad87e) to head (6f2770e).

Files Patch % Lines
pkg/detector/detector.go 0.00% 38 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4836 +/- ## ========================================== - Coverage 53.11% 53.07% -0.05% ========================================== Files 250 250 Lines 20351 20369 +18 ========================================== Hits 10810 10810 - Misses 8824 8842 +18 Partials 717 717 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4836/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.07% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

whitewindmills commented 2 weeks ago

/cc @RainbowMango @XiShanYongYe-Chang

RainbowMango commented 2 weeks ago

/assign

RainbowMango commented 2 weeks ago

LGTM @XiShanYongYe-Chang @chaunceyjiang Do you guys have any further comments?

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment