karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

feat: ability to suspend `Work` #4838

Open a7i opened 2 weeks ago

a7i commented 2 weeks ago

What type of PR is this?

/kind feature

What this PR does / why we need it: Ability to suspend work to ensure that changes are not being reconciled.

Which issue(s) this PR fixes: Fixes https://github.com/karmada-io/karmada/issues/4688

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ability to suspend Work to ensure that changes are not being reconciled.
karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign garrybest after the PR has been reviewed. You can assign the PR to them by writing /assign @garrybest in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 52.60%. Comparing base (b38bc26) to head (5e29d59).

Files Patch % Lines
pkg/detector/detector.go 0.00% 5 Missing :warning:
pkg/controllers/binding/common.go 50.00% 2 Missing :warning:
pkg/util/helper/work.go 0.00% 2 Missing :warning:
...controllers/unifiedauth/unified_auth_controller.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4838 +/- ## ========================================== - Coverage 52.98% 52.60% -0.38% ========================================== Files 250 251 +1 Lines 20420 20592 +172 ========================================== + Hits 10819 10832 +13 - Misses 8882 9036 +154 - Partials 719 724 +5 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4838/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4838/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `52.60% <44.44%> (-0.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 week ago

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: CharlesQQ.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/karmada-io/karmada/pull/4838#discussion_r1571942026): >Do we need to consider setting pause fields for different clusters so that different pause policies can be set for different work of the same resource? > >/cc @CharlesQQ @RainbowMango Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a7i commented 1 week ago

@XiShanYongYe-Chang What's your feeling on this PR? Should I rebase and keep it up to date or do you not see this as a feature?

XiShanYongYe-Chang commented 1 week ago

I agree with this feature. I'm currently working on this area to see if karmada can provide users with faster capabilities based on this. I'll sync when I make progress. Thanks.