Closed veophi closed 1 week ago
Welcome @veophi! It looks like this is your first PR to karmada-io/karmada 🎉
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.10%. Comparing base (
fdad87e
) to head (9bcd852
). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @veophi, I notice you are from the openkruise community, so it makes sense for you to maintain the resource customizations of apps.kruise.io
.
/assign @yike21 @chaunceyjiang To take a look, and do we need to update the tests as well?
/assign @yike21 @chaunceyjiang To take a look, and do we need to update the tests as well?
From the code it looks fine, I'll do the test asap!
Glad to see your contribution! @veophi
/lgtm
Thank you @yike21 .
And the test-data need to be updated. I will do it soon.
Seems we still lack of a mechanism to run these test automatically?
/assign @chaunceyjiang
Seems we still lack of a mechanism to run these test automatically?
The tests are executed automatically. The test program ensures that the resourcecustomizations directory is structured with the test files and that the karmadactl interpert
is executed without errors. This is useful when adding a new customizaitons.yaml for thirdparty CRD.
However, when an existing customizations.yaml
for some thirdparty CRD is modified, the testdata
related may need to be analyzed and modified again to characterize the new interpretation rules.
Get it. Thanks for the explanation. We have tests and they work as expected, we just need to add new fields to them, as #4849 does.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chaunceyjiang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: