karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

feat: show `status.labelSelector` for CloneSet #4839

Closed veophi closed 1 week ago

veophi commented 2 weeks ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-bot commented 2 weeks ago

Welcome @veophi! It looks like this is your first PR to karmada-io/karmada 🎉

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.10%. Comparing base (fdad87e) to head (9bcd852). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4839 +/- ## ========================================== - Coverage 53.11% 53.10% -0.01% ========================================== Files 250 250 Lines 20351 20351 ========================================== - Hits 10810 10808 -2 - Misses 8824 8826 +2 Partials 717 717 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4839/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.10% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 2 weeks ago

Thanks @veophi, I notice you are from the openkruise community, so it makes sense for you to maintain the resource customizations of apps.kruise.io.

/assign @yike21 @chaunceyjiang To take a look, and do we need to update the tests as well?

yike21 commented 2 weeks ago

/assign @yike21 @chaunceyjiang To take a look, and do we need to update the tests as well?

From the code it looks fine, I'll do the test asap!

Glad to see your contribution! @veophi

yike21 commented 1 week ago

/lgtm

RainbowMango commented 1 week ago

Thank you @yike21 .

And the test-data need to be updated. I will do it soon.

Seems we still lack of a mechanism to run these test automatically?

RainbowMango commented 1 week ago

/assign @chaunceyjiang

yike21 commented 1 week ago

Seems we still lack of a mechanism to run these test automatically?

The tests are executed automatically. The test program ensures that the resourcecustomizations directory is structured with the test files and that the karmadactl interpert is executed without errors. This is useful when adding a new customizaitons.yaml for thirdparty CRD.

However, when an existing customizations.yaml for some thirdparty CRD is modified, the testdata related may need to be analyzed and modified again to characterize the new interpretation rules.

RainbowMango commented 1 week ago

Get it. Thanks for the explanation. We have tests and they work as expected, we just need to add new fields to them, as #4849 does.

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/resourceinterpreter/default/thirdparty/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/resourceinterpreter/default/thirdparty/OWNERS)~~ [chaunceyjiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment