karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Introduce a new API named WorkloadRebalancer to support rescheduling #4841

Closed chaosi-zju closed 1 week ago

chaosi-zju commented 2 weeks ago

What type of PR is this?

/kind api-change /kind feature

What this PR does / why we need it:

Introduce a new API named WorkloadRebalancer to support rescheduling

Which issue(s) this PR fixes:

Fixes part of #4840

Special notes for your reviewer:

DO NOT MERGE until the following PR have been merged:

Does this PR introduce a user-facing change?:

Introduce a new API named WorkloadRebalancer to support rescheduling.
chaosi-zju commented 2 weeks ago

@XiShanYongYe-Chang @RainbowMango could you please take some time to help review it?

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.98%. Comparing base (aded7c0) to head (c600991). Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4841 +/- ## ========================================== - Coverage 52.99% 52.98% -0.01% ========================================== Files 250 250 Lines 20420 20421 +1 ========================================== - Hits 10821 10820 -1 - Misses 8880 8882 +2 Partials 719 719 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4841/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4841/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `52.98% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 1 week ago

Please fix the comments and remove the ResourceBinding part as it's in #4848.

chaosi-zju commented 1 week ago

Please fix the comments and remove the ResourceBinding part as it's in #4848.

this PR should rebase after #4848 merged, the new introduced field in ResourceBinding is also useful in this PR.

RainbowMango commented 1 week ago

Please rebase and fix failing tests.

chaosi-zju commented 1 week ago

Please rebase and fix failing tests.

done, ready to review @RainbowMango @XiShanYongYe-Chang

I have finished testing this PR too.

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
XiShanYongYe-Chang commented 1 week ago

/lgtm