Closed chaosi-zju closed 1 week ago
@XiShanYongYe-Chang @RainbowMango could you please take some time to help review it?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.98%. Comparing base (
aded7c0
) to head (c600991
). Report is 6 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please fix the comments and remove the ResourceBinding part as it's in #4848.
Please fix the comments and remove the ResourceBinding part as it's in #4848.
this PR should rebase after #4848 merged, the new introduced field in ResourceBinding is also useful in this PR.
Please rebase and fix failing tests.
Please rebase and fix failing tests.
done, ready to review @RainbowMango @XiShanYongYe-Chang
I have finished testing this PR too.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What type of PR is this?
/kind api-change /kind feature
What this PR does / why we need it:
Introduce a new API named WorkloadRebalancer to support rescheduling
Which issue(s) this PR fixes:
Fixes part of #4840
Special notes for your reviewer:
DO NOT MERGE until the following PR have been merged:
4848
Does this PR introduce a user-facing change?: