Open a7i opened 2 weeks ago
Attention: Patch coverage is 60.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 53.10%. Comparing base (
fdad87e
) to head (0b15cb7
). Report is 8 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/resourceinterpreter/default/native/retain.go | 33.33% | 4 Missing and 2 partials :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM @a7i, can you help squash the commit into one?
Hi @a7i, can you help add the component name to the release note?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chaunceyjiang
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/remove-hold
/retest-required
/assign @rainbowmango
What type of PR is this?
/kind bug
What this PR does / why we need it:
As my colleague @jklaw90 discovered that selected-node is for the node that volume is mounted on. If this node doesn't exist, then it is never removed. See upstream issue: https://github.com/kubernetes/kubernetes/issues/100485
we should also remove this field since it's irrelevant, given that node names are likely not going to be the same.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: