Closed chaosi-zju closed 1 week ago
Attention: Patch coverage is 26.31579%
with 56 lines
in your changes are missing coverage. Please review.
Project coverage is 52.97%. Comparing base (
fdad87e
) to head (0372cab
). Report is 14 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ready to review, already tested @RainbowMango
I tend to start with the proposal(#4698).
/assign @XiShanYongYe-Chang
/lgtm
@XiShanYongYe-Chang Do you have any further comments?
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind api-change /kind feature
What this PR does / why we need it:
Introduce a mechanism to scheduler to actively trigger rescheduling
Which issue(s) this PR fixes:
Fixes part of #4840
Special notes for your reviewer:
How to test it:
resource.yaml
```yaml apiVersion: apps/v1 kind: Deployment metadata: name: demo-test-1 labels: app: test spec: replicas: 3 selector: matchLabels: app: demo-test-1 template: metadata: labels: app: demo-test-1 spec: terminationGracePeriodSeconds: 0 containers: - image: nginx name: demo-test-1 resources: limits: cpu: 10m memory: 10Mi --- apiVersion: policy.karmada.io/v1alpha1 kind: PropagationPolicy metadata: name: default-pp spec: placement: clusterAffinity: clusterNames: - member1 - member2 replicaScheduling: replicaDivisionPreference: Weighted replicaSchedulingType: Divided weightPreference: dynamicWeight: AvailableReplicas resourceSelectors: - apiVersion: apps/v1 kind: Deployment name: demo-test-1 namespace: default ```spec.rescheduleTriggeredAt
binding manually, like:spec.cluster
andstatus.lastScheduledTime
updated.Does this PR introduce a user-facing change?: