karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

fix: update testdata for resourcecustomizations of CloneSet #4849

Closed yike21 closed 6 days ago

yike21 commented 1 week ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: It's related to #4839. The testdata for resourcecustomizations/apps.kruise.io/v1alpha1/CloneSet should be updated. Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.06%. Comparing base (20bb7a7) to head (729b4fe).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4849 +/- ## ======================================= Coverage 53.05% 53.06% ======================================= Files 250 250 Lines 20371 20371 ======================================= + Hits 10808 10810 +2 + Misses 8845 8844 -1 + Partials 718 717 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4849/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4849/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.06% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 1 week ago

/assign @chaunceyjiang

yike21 commented 1 week ago

Thank you for your work, could you rebase the master branch again?

Yes, I will do it soon!

karmada-bot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/resourceinterpreter/default/thirdparty/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/resourceinterpreter/default/thirdparty/OWNERS)~~ [chaunceyjiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment