search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Bump arduino/setup-protoc from 1 to 3 #4856

Closed dependabot[bot] closed 5 days ago

dependabot[bot] commented 1 week ago

Bumps arduino/setup-protoc from 1 to 3.

Release notes

Sourced from arduino/setup-protoc's releases.

v3.0.0

What's Changed

New Contributors

Full Changelog: https://github.com/arduino/setup-protoc/compare/v2.1.0...v3.0.0

v2.1.0

What's Changed

New Contributors

Full Changelog: https://github.com/arduino/setup-protoc/compare/v2.0.0...v2.1.0

v2.0.0

Changelog

Adding support for the MINOR.PATCH tag naming

Breaking

Full Changelog: https://github.com/arduino/setup-protoc/compare/v1.3.0...v2.0.0

Contributors

v1.3.0

Changelog

Enhancement

  • Support ARM64 and other platforms (#44 )

Full Changeset

https://github.com/arduino/setup-protoc/compare/v1.2.0...v1.3.0

Contributors

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign liangyuanpeng after the PR has been reviewed. You can assign the PR to them by writing /assign @liangyuanpeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[.github/workflows/OWNERS](https://github.com/karmada-io/karmada/blob/master/.github/workflows/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liangyuanpeng commented 1 week ago

Seems the test is failing

The reason is protobuf is using the new version style since 3.21.x, change vMAJOR.MINOR.PTACH to vMINOR.PATCH, example: the v3.21.0 is v21.0 now.

More details here:

And arduino/setup-protoc is working for version style of vMINOR.PATCH since arduino/setup-protoc@v2

One possible resolution can be to not update arduino/setup-protoc version. Other possible solution is to use protoc version(minor version) in workflows

REF https://github.com/rudderlabs/rudder-server/pull/4150#issuecomment-1822285490

cc @RainbowMango

RainbowMango commented 1 week ago

So, what's your suggestion?

liangyuanpeng commented 1 week ago

what's your suggestion?

Keeping arduino/setup-protoc at v1 unless we would like to use a specially protoc version.

chaosi-zju commented 5 days ago

hi @liangyuanpeng, do you mean:

arduino/setup-protoc@v1 works with libprotoc vMAJOR.MINOR.PTACH arduino/setup-protoc@v3 works with libprotoc vMINOR.PATCH

Since our libprotoc version is vMAJOR.MINOR.PTACH, we can only use arduino/setup-protoc@v1 instead of arduino/setup-protoc@v3 ?

So, Is vMINOR.PATCH this version style newer? If it is, can we update libprotoc to latest version too ?

chaosi-zju commented 5 days ago

I prefer using arduino/setup-protoc@v3 and install latest version protoc.

Just remove version: '3.x' or change to version: '23.x' works, i.e:

- name: Install Protoc
  uses: arduino/setup-protoc@v3
  with:
    version: '23.4'
    # Use the automatic token, so that this task can be run in the forked repo.
    # https://docs.github.com/en/actions/security-guides/automatic-token-authentication
    repo-token: ${{ secrets.GITHUB_TOKEN }}

test report: https://github.com/chaosi-zju/karmada/actions/runs/8866877222/job/24344830812

the previous version field actually is a wildcard, if you want to pin a major or minor version you can use a wildcard like 3.x.

For example, libprotoc v3.x.x can be searched by arduino/setup-protoc@v1, while not by arduino/setup-protoc@v3, if you specified wildcard version: '3.x', arduino/setup-protoc@v1 can work successful, while arduino/setup-protoc@v3 will report unable to get latest version.

so, just remove the version limit version: '3.x' or defined it as version: '23.x', which version can be searched by arduino/setup-protoc@v3. (refer to setup-protoc)

dependabot[bot] commented 5 days ago

Looks like arduino/setup-protoc is up-to-date now, so this is no longer needed.