Closed chaosi-zju closed 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango
in a comment when ready.
The full list of commands accepted by this bot can be found here.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.97%. Comparing base (
aded7c0
) to head (09f93bd
). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/close
we will try to implemente update
event in #4860
@chaosi-zju: Closed this PR.
DO NOT MERGE until the following PR have been merged (this PR needs a rebasing) :
4841
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduce a validation webhook to prohibit WorkloadRebalancer from being modified, the final effect is like:
Which issue(s) this PR fixes:
Fixes part of #4840
Special notes for your reviewer:
Does this PR introduce a user-facing change?: