karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

Add image-pull-policy field for karmada-operator #4863

Closed seanlaii closed 1 week ago

seanlaii commented 1 week ago

What type of PR is this?

/kind feature

What this PR does / why we need it: https://github.com/karmada-io/karmada/issues/4789

Which issue(s) this PR fixes: Part of https://github.com/karmada-io/karmada/issues/4789

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow the user to specify `imagePullPolicy` in Karmada CR when installing via karmada-operator.
karmada-bot commented 1 week ago

Welcome @seanlaii! It looks like this is your first PR to karmada-io/karmada 🎉

XiShanYongYe-Chang commented 1 week ago

@seanlaii Thanks a lot~ /cc @calvin0327 @zhzhuang-zju

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.98%. Comparing base (20bb7a7) to head (d78ea38). Report is 16 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4863 +/- ## ========================================== - Coverage 53.05% 52.98% -0.08% ========================================== Files 250 250 Lines 20371 20421 +50 ========================================== + Hits 10808 10820 +12 - Misses 8845 8882 +37 - Partials 718 719 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4863/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4863/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `52.98% <ø> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zhzhuang-zju commented 1 week ago

@seanlaii nice job~ /lgtm

btw, we can continous to push forward https://github.com/karmada-io/karmada/pull/4401 to add validation of the installation method of the operatoris installed. @XiShanYongYe-Chang

zhzhuang-zju commented 1 week ago

/lgtm

calvin0327 commented 1 week ago

/lgtm

thanks for doing this.

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[charts/OWNERS](https://github.com/karmada-io/karmada/blob/master/charts/OWNERS)~~ [RainbowMango] - ~~[operator/OWNERS](https://github.com/karmada-io/karmada/blob/master/operator/OWNERS)~~ [RainbowMango] - ~~[operator/pkg/apis/OWNERS](https://github.com/karmada-io/karmada/blob/master/operator/pkg/apis/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment