karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

etcd:Update version to 3.5.13 #4864

Closed rohit-satya closed 1 week ago

rohit-satya commented 1 week ago

Close https://github.com/karmada-io/karmada/issues/4862

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

etcd: update version to 3.5.13
karmada-bot commented 1 week ago

Welcome @rohit-satya! It looks like this is your first PR to karmada-io/karmada 🎉

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.98%. Comparing base (6e5a602) to head (71e203e). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4864 +/- ## ======================================= Coverage 52.98% 52.98% ======================================= Files 250 250 Lines 20421 20421 ======================================= + Hits 10820 10821 +1 + Misses 8881 8880 -1 Partials 720 720 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4864/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4864/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `52.98% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangyuanpeng commented 1 week ago

@rohit-satya Thanks for working it and please follow the https://github.com/karmada-io/karmada/pull/4864/checks?check_run_id=24187866088 to sign DCO.

RainbowMango commented 1 week ago

/approve

Leave LGTM to @liangyuanpeng for final decision.

Thank you @rohit-satya for doing this.

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liangyuanpeng commented 1 week ago

/lgtm Thanks