Closed XiShanYongYe-Chang closed 1 week ago
/cc @RainbowMango
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 52.97%. Comparing base (
6e5a602
) to head (a16b4e2
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...controllers/unifiedauth/unified_auth_controller.go | 0.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Test result:
# kubectl create ns test12345678901234567890123456789012345678901234567890123456789
namespace/test12345678901234567890123456789012345678901234567890123456789 created
# km1 get ns
NAME STATUS AGE
default Active 13m
karmada-cluster Active 7m43s
kube-node-lease Active 13m
kube-public Active 13m
kube-system Active 13m
local-path-storage Active 13m
test12345678901234567890123456789012345678901234567890123456789 Active 7s
@whitewindmills Thanks a lot! I update it.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
When we create a namespace with a length of 63, the namespace will not be synchronized to the member cluster. The error reported in
karmada-controller-manager
is as follows:Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
We miss update it in the #4765
Does this PR introduce a user-facing change?: