Open veophi opened 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Attention: Patch coverage is 24.00000%
with 19 lines
in your changes are missing coverage. Please review.
Project coverage is 53.04%. Comparing base (
6e5a602
) to head (62b976f
). Report is 16 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @veophi can you help fix the lint error?
/assign @yike21
Hi @veophi can you help fix the lint error?
@XiShanYongYe-Chang fixed.
Hi @veophi, Is this pr ready? If it is ready, you can remove the WIP info in the title. Then the work-in-progress label will be removed, indicating that the current pr is ready.
In addition, you can add the issue number of the current pr to the end of Fiexs
, like this:
**Which issue(s) this PR fixes:**
Fixes #4866
and GitHub will automatically associate it with the issue. After the pr is merged, the associated issue will be closed.
New changes are detected. LGTM label has been removed.
Part of #4870 /kind feature Hi @veophi, can you help add the release note.
I see that there is a lot of discussion about this pr and the issues are quite in-depth. This means that the PR solution is very important to Karmada. Can we organize a meeting or discussion group to discuss this issue?
@veophi @whitewindmills @yike21
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes: Fixes #4866
Special notes for your reviewer:
Does this PR introduce a user-facing change?: