karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

fix: Deployment generation/observedGeneration bug #4867

Open veophi opened 1 week ago

veophi commented 1 week ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #4866

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 53.04%. Comparing base (6e5a602) to head (62b976f). Report is 16 commits behind head on master.

Files Patch % Lines
pkg/controllers/status/work_status_controller.go 0.00% 9 Missing :warning:
...esourceinterpreter/default/native/reflectstatus.go 0.00% 8 Missing :warning:
...ourceinterpreter/default/native/aggregatestatus.go 71.42% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4867 +/- ## ========================================== + Coverage 52.98% 53.04% +0.05% ========================================== Files 250 251 +1 Lines 20421 20411 -10 ========================================== + Hits 10820 10826 +6 + Misses 8881 8871 -10 + Partials 720 714 -6 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4867/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.04% <24.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 week ago

Hi @veophi can you help fix the lint error?

XiShanYongYe-Chang commented 1 week ago

/assign @yike21

veophi commented 1 week ago

Hi @veophi can you help fix the lint error?

@XiShanYongYe-Chang fixed.

XiShanYongYe-Chang commented 1 week ago

Hi @veophi, Is this pr ready? If it is ready, you can remove the WIP info in the title. Then the work-in-progress label will be removed, indicating that the current pr is ready.

In addition, you can add the issue number of the current pr to the end of Fiexs, like this:

**Which issue(s) this PR fixes:**
Fixes #4866

and GitHub will automatically associate it with the issue. After the pr is merged, the associated issue will be closed.

karmada-bot commented 1 week ago

New changes are detected. LGTM label has been removed.

XiShanYongYe-Chang commented 1 week ago

Part of #4870 /kind feature Hi @veophi, can you help add the release note.

XiShanYongYe-Chang commented 1 week ago

I see that there is a lot of discussion about this pr and the issues are quite in-depth. This means that the PR solution is very important to Karmada. Can we organize a meeting or discussion group to discuss this issue?

@veophi @whitewindmills @yike21