karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.12k stars 807 forks source link

[Umbrella] Align generation and observedGeneration fields by reflectstatus and aggregatestatus operation #4870

Open yike21 opened 1 week ago

yike21 commented 1 week ago

What would you like to be added: There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

karmada-bot commented 1 week ago

@yike21: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/karmada-io/karmada/issues/4870): > > >**What would you like to be added**: >There are some third-party resources and native resources that need to align `.metadata.generation` and `.status.observedGeneration ` fields. Please ref to #4866 . > >**Why is this needed**: > >Continue the work of #4867 and break down the tasks to be done. >- native resource > - [ ] GroupVersion: apps/v1 > kind: > - [ ] Deployment @veophi #4867 > - [ ] DaemonSet > - [ ] StatefulSet >- Thirdparty resource > - [ ] GroupVersion: apps.kruise.io/v1alpha1 > kind: > - [ ] CloneSet > - [ ] DaemonSet > - [ ] GroupVersion: apps.kruise.io/v1beta1 > kind: > - [ ] StatefulSet > - [ ] GroupVersion: helm.toolkit.fluxcd.io/v2beta1 > kind: > - [ ] HelmRelease > - [ ] GroupVersion: kustomize.toolkit.fluxcd.io/v1 > kind: > - [ ] Kustomization > - [ ] GroupVersion: source.toolkit.fluxcd.io/v1 > kind: > - [ ] GitRepository > - [ ] GroupVersion: source.toolkit.fluxcd.io/v1beta2 > kind: > - [ ] Bucket > - [ ] HelmChart > - [ ] HelmRepository > - [ ] OCIRepository > >We need to examine the meaning of `.metadata.generation` and `.status.observedGeneration` fields for each resource above, and then modify the `ReflectStatus` and `AggregateStatus` operations to align them. The modifications are likely to be similar, so please wait for `CloneSet` and `Deployment` modifications to be completed. > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
liangyuanpeng commented 1 week ago

I want to try it for StatefulSet

yike21 commented 1 week ago

I want to try it for StatefulSet

Thanks a lot~

XiShanYongYe-Chang commented 1 week ago

@yike21 Good Job!

whitewindmills commented 1 week ago

I wanna pick up DaemonSet, thanks.

yike21 commented 1 week ago

I wanna pick up DaemonSet, thanks.

ok, thanks a lot~