karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 811 forks source link

add ut for WorkloadRebalancer controller #4876

Closed chaosi-zju closed 1 week ago

chaosi-zju commented 2 weeks ago

DO NOT MERGE until the following PR have been merged:

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add ut for WorkloadRebalancer controller

Which issue(s) this PR fixes:

Fixes part of #4840

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.17%. Comparing base (4a0876c) to head (2b7d07b). Report is 14 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4876 +/- ## ========================================== + Coverage 53.13% 53.17% +0.04% ========================================== Files 251 252 +1 Lines 20415 20525 +110 ========================================== + Hits 10847 10914 +67 - Misses 8854 8892 +38 - Partials 714 719 +5 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4876/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4876/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.17% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 2 weeks ago

/hold for #4875

chaosi-zju commented 1 week ago

/hold cancel

chaosi-zju commented 1 week ago

cc @XiShanYongYe-Chang

chaosi-zju commented 1 week ago

is there any more comments?

RainbowMango commented 1 week ago

/assign

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/controllers/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment