search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 811 forks source link

ObjectWatcher.Delete checks if resource can be deleted #4880

Closed whitewindmills closed 2 weeks ago

whitewindmills commented 2 weeks ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: Split from https://github.com/karmada-io/karmada/pull/4813. See https://github.com/karmada-io/karmada/pull/4813#discussion_r1560759930

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
whitewindmills commented 2 weeks ago

/cc @XiShanYongYe-Chang @RainbowMango

XiShanYongYe-Chang commented 2 weeks ago

Thanks @whitewindmills /assign

XiShanYongYe-Chang commented 2 weeks ago

Ask @chaunceyjiang to help take a review. /cc @chaunceyjiang

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.08%. Comparing base (81916d6) to head (f9f3d47). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4880 +/- ## ========================================== + Coverage 53.07% 53.08% +0.01% ========================================== Files 251 251 Lines 20389 20389 ========================================== + Hits 10821 10824 +3 + Misses 8855 8852 -3 Partials 713 713 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4880/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4880/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.08% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/controllers/OWNERS)~~ [RainbowMango] - ~~[pkg/util/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/util/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment